[pjsip] reinvite causes assertion failure

[Klaus Darilion]

Benny Prijono schrieb:
> On Thu, Oct 8, 2009 at 4:02 PM, Daniel Nanassy <Daniel.Nanassy at ygomi.com> wrote:
>> Yes, Asterisk sends the re-INVITE with the same Via branch.
>> Here is a short excerpt from the RFC-3261 (SIP):
>>
>> 8.1.1.7 Via
>> ...
>> The branch parameter value MUST be unique across space and time for
>> all requests sent by the UA.  The exceptions to this rule are CANCEL
>> and ACK for non-2xx responses.  As discussed below, a CANCEL request
>> will have the same value of the branch parameter as the request it
>> cancels.  As discussed in Section 17.1.1.3, an ACK for a non-2xx
>> response will also have the same branch ID as the INVITE whose
>> response it acknowledges.
>> ...
>>
>> Do you think Asterisk should send re-INVITE with another branch?

Probably this is related to this Asterisk fix:

2009-09-18 23:19 +0000 [r219450-219519]  David Vossel <dvossel at digium.com>

	* channels/chan_iax2.c: iax2 frame double free The iax frame's
	  retrans sched id was written over right before iax2_frame_free
	  was called. In iax2_frame_free that retrans id is used to delete
	  the sched item. By writing over the retrans field before the
	  sched item could be deleted, it was possible for a retransmit to
	  occur on a freed frame.

	* channels/chan_sip.c: via-header branches not updated correctly on
	  INVITE INVITE requests must always contain a new unique branch
	  id. When a new branch id is created for an INVITE, the dialog's
	  invite_branch variable must be updated so CANCEL requests use the
	  correct branch id. (closes issue #15262) Reported by: maniax
	  Patches: asterisk-1.6.1.0-sip-branch.patch uploaded by tweety
	  (license 608) invite_new_branch_trunk.diff uploaded by dvossel
	  (license 671) Tested by: maniax, dvossel


klaus

> 
> Absolutely.
> 
> Cheers
>  Benny
> 
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
> 
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org