[PATCH] Re: wav-player broken for CCITT u/a-law files in 1.10 (and 2.x) after Ticket #597

ES
Eize Slange
Thu, Oct 20, 2011 9:55 AM

Hello Benny,

I probably have the solution for mentioned problem. It was indeed that the
fport->data_left wasn't updated on a file-position change.
Please have a check if I did not oversee something, and please add it to the
1.x and 2.x tree.

File: wav-player.c
Function: pjmedia_wav_player_port_set_pos

Add next code after the last PJ_ASSERT_RETURN:

/* Check that this offset does not pass the audio-data (in case of
   extra chunk after audio data chunk */
PJ_ASSERT_RETURN(bytes < fport->data_len, PJ_EINVAL);
fport->data_left = fport->data_len - bytes;

With regards,

Eize Slange

Hello Benny, I probably have the solution for mentioned problem. It was indeed that the fport->data_left wasn't updated on a file-position change. Please have a check if I did not oversee something, and please add it to the 1.x and 2.x tree. File: wav-player.c Function: pjmedia_wav_player_port_set_pos Add next code after the last PJ_ASSERT_RETURN: /* Check that this offset does not pass the audio-data (in case of extra chunk after audio data chunk */ PJ_ASSERT_RETURN(bytes < fport->data_len, PJ_EINVAL); fport->data_left = fport->data_len - bytes; With regards, Eize Slange
BP
Benny Prijono
Sun, Oct 23, 2011 8:19 AM

On Thu, Oct 20, 2011 at 10:55 AM, Eize Slange eize.slange@gmail.com wrote:

Hello Benny,

I probably have the solution for mentioned problem. It was indeed that the
fport->data_left wasn't updated on a file-position change.
Please have a check if I did not oversee something, and please add it to the
1.x and 2.x tree.

I just tried your WAV file with pjsua from the latest 1.x and 2.0, and
it sounds fine to me, with or without playback loop. Can you tell me
the exact way to reproduce it?

Benny

On Thu, Oct 20, 2011 at 10:55 AM, Eize Slange <eize.slange@gmail.com> wrote: > Hello Benny, > > I probably have the solution for mentioned problem. It was indeed that the > fport->data_left wasn't updated on a file-position change. > Please have a check if I did not oversee something, and please add it to the > 1.x and 2.x tree. > I just tried your WAV file with pjsua from the latest 1.x and 2.0, and it sounds fine to me, with or without playback loop. Can you tell me the exact way to reproduce it? Benny